Commit 3f2571fe authored by Vasant Hegde's avatar Vasant Hegde Committed by Joerg Roedel
Browse files

iommu/amd: Remove redundant domain flush from attach_device() 



Domain flush was introduced in attach_device() path to handle kdump
scenario. Later init code was enhanced to handle kdump scenario where
it also takes care of flushing everything including TLB
(see early_enable_iommus()).

Hence remove redundant flush from attach_device() function.

Signed-off-by: default avatarVasant Hegde <vasant.hegde@amd.com>
Reviewed-by: default avatarSuravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Link: https://lore.kernel.org/r/20231122090215.6191-3-vasant.hegde@amd.com


Signed-off-by: default avatarJoerg Roedel <jroedel@suse.de>
parent af326375

drivers/iommu/amd/iommu.c

+0 −9
Original line number Diff line number Diff line
@@ -1896,15 +1896,6 @@ static int attach_device(struct device *dev, 


	do_attach(dev_data, domain);



	/*

	 * We might boot into a crash-kernel here. The crashed kernel

	 * left the caches in the IOMMU dirty. So we have to flush

	 * here to evict all dirty stuff.

	 */

	amd_iommu_domain_flush_tlb_pde(domain);



	amd_iommu_domain_flush_complete(domain);



out:

	spin_unlock(&dev_data->lock);