Commit 563307e9 authored by Jakub Kicinski's avatar Jakub Kicinski
Browse files

Merge branch 'mana-fix-few-memory-leaks-in-mana_gd_setup_irqs' 

Maxim Levitsky says:

====================
MANA: Fix few memory leaks in mana_gd_setup_irqs

Fix 2 minor memory leaks in the mana driver,
introduced by commit
====================

Link: https://patch.msgid.link/20241209175751.287738-1-mlevitsk@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parents 15bfb147 9a5beb6c

drivers/net/ethernet/microsoft/mana/gdma_main.c

+4 −2
Original line number Diff line number Diff line
@@ -1318,7 +1318,7 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev) 
				   GFP_KERNEL);

	if (!gc->irq_contexts) {

		err = -ENOMEM;

		goto free_irq_vector;

		goto free_irq_array;

	}



	for (i = 0; i < nvec; i++) {
@@ -1375,6 +1375,7 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev) 
	gc->max_num_msix = nvec;

	gc->num_msix_usable = nvec;

	cpus_read_unlock();

	kfree(irqs);

	return 0;



free_irq:
@@ -1387,8 +1388,9 @@ static int mana_gd_setup_irqs(struct pci_dev *pdev) 
	}



	kfree(gc->irq_contexts);

	kfree(irqs);

	gc->irq_contexts = NULL;

free_irq_array:

	kfree(irqs);

free_irq_vector:

	cpus_read_unlock();

	pci_free_irq_vectors(pdev);