Commit 5cb14f15 authored by Breno Leitao's avatar Breno Leitao Committed by Greg Kroah-Hartman
Browse files

misc: bcm_vk: Remove usage of deprecated functions 



ida_simple_get() and ida_simple_remove() functions are deprecated now.
These functions were replaced by ida_alloc() and ida_free()
respectively. This patch modernize bcm_vk to use the replacement
functions.

Acked-by: default avatarScott Branden <scott.branden@broadcom.com>
Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20220812094717.4097179-1-leitao@debian.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent fccf202e

drivers/misc/bcm-vk/bcm_vk_dev.c

+3 −3
Original line number Diff line number Diff line
@@ -1401,7 +1401,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
		bcm_vk_tty_set_irq_enabled(vk, i);

	}



	id = ida_simple_get(&bcm_vk_ida, 0, 0, GFP_KERNEL);

	id = ida_alloc(&bcm_vk_ida, GFP_KERNEL);

	if (id < 0) {

		err = id;

		dev_err(dev, "unable to get id\n");
@@ -1500,7 +1500,7 @@ static int bcm_vk_probe(struct pci_dev *pdev, const struct pci_device_id *ent) 
	misc_device->name = NULL;



err_ida_remove:

	ida_simple_remove(&bcm_vk_ida, id);

	ida_free(&bcm_vk_ida, id);



err_irq:

	for (i = 0; i < vk->num_irqs; i++)
@@ -1573,7 +1573,7 @@ static void bcm_vk_remove(struct pci_dev *pdev) 
	if (misc_device->name) {

		misc_deregister(misc_device);

		kfree(misc_device->name);

		ida_simple_remove(&bcm_vk_ida, vk->devid);

		ida_free(&bcm_vk_ida, vk->devid);

	}

	for (i = 0; i < vk->num_irqs; i++)

		devm_free_irq(&pdev->dev, pci_irq_vector(pdev, i), vk);