Commit 5e3eedf5 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski
Browse files

gpio: mpsse: Check for error code from devm_mutex_init() call 



Even if it's not critical, the avoidance of checking the error code
from devm_mutex_init() call today diminishes the point of using devm
variant of it. Tomorrow it may even leak something. Add the missed
check.

Fixes: c46a74ff ("gpio: add support for FTDI's MPSSE as GPIO")
Reviewed-by: default avatarMary Strodl <mstrodl@csh.rit.edu>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20241030174132.2113286-2-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent a22c9dc2

drivers/gpio/gpio-mpsse.c

+7 −2
Original line number Diff line number Diff line
@@ -430,8 +430,13 @@ static int gpio_mpsse_probe(struct usb_interface *interface, 
	if (err)

		return err;



	devm_mutex_init(dev, &priv->io_mutex);

	devm_mutex_init(dev, &priv->irq_mutex);

	err = devm_mutex_init(dev, &priv->io_mutex);

	if (err)

		return err;



	err = devm_mutex_init(dev, &priv->irq_mutex);

	if (err)

		return err;



	priv->gpio.label = devm_kasprintf(dev, GFP_KERNEL,

					  "gpio-mpsse.%d.%d",