Commit 60253042 authored by Shay Drory's avatar Shay Drory Committed by Jakub Kicinski
Browse files

net/mlx5: Fix missing devlink lock in SRIOV enable error path 



The cited commit miss to add locking in the error path of
mlx5_sriov_enable(). When pci_enable_sriov() fails,
mlx5_device_disable_sriov() is called to clean up. This cleanup function
now expects to be called with the devlink instance lock held.

Add the missing devl_lock(devlink) and devl_unlock(devlink)

Fixes: 84a433a4 ("net/mlx5: Lock mlx5 devlink reload callbacks")
Signed-off-by: default avatarShay Drory <shayd@nvidia.com>
Reviewed-by: default avatarMark Bloch <mbloch@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260224114652.1787431-5-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent d7073e8b

drivers/net/ethernet/mellanox/mlx5/core/sriov.c

+2 −0
Original line number Diff line number Diff line
@@ -193,7 +193,9 @@ static int mlx5_sriov_enable(struct pci_dev *pdev, int num_vfs) 
	err = pci_enable_sriov(pdev, num_vfs);

	if (err) {

		mlx5_core_warn(dev, "pci_enable_sriov failed : %d\n", err);

		devl_lock(devlink);

		mlx5_device_disable_sriov(dev, num_vfs, true, true);

		devl_unlock(devlink);

	}

	return err;

}