Commit 637c3054 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

gpio: wcd934x: use new GPIO line value setter callbacks 

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Link: https://lore.kernel.org/r/20250709-gpiochip-set-rv-gpio-remaining-v1-3-b8950f69618d@linaro.org


Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
parent ff0f0d7c

drivers/gpio/gpio-wcd934x.c

+5 −4
Original line number Diff line number Diff line
@@ -68,12 +68,13 @@ static int wcd_gpio_get(struct gpio_chip *chip, unsigned int pin) 
	return !!(value & WCD_PIN_MASK(pin));

}



static void wcd_gpio_set(struct gpio_chip *chip, unsigned int pin, int val)

static int wcd_gpio_set(struct gpio_chip *chip, unsigned int pin, int val)

{

	struct wcd_gpio_data *data = gpiochip_get_data(chip);



	regmap_update_bits(data->map, WCD_REG_VAL_CTL_OFFSET,

			   WCD_PIN_MASK(pin), val ? WCD_PIN_MASK(pin) : 0);

	return regmap_update_bits(data->map, WCD_REG_VAL_CTL_OFFSET,

				  WCD_PIN_MASK(pin),

				  val ? WCD_PIN_MASK(pin) : 0);

}



static int wcd_gpio_probe(struct platform_device *pdev)
@@ -97,7 +98,7 @@ static int wcd_gpio_probe(struct platform_device *pdev) 
	chip->direction_output = wcd_gpio_direction_output;

	chip->get_direction = wcd_gpio_get_direction;

	chip->get = wcd_gpio_get;

	chip->set = wcd_gpio_set;

	chip->set_rv = wcd_gpio_set;

	chip->parent = dev;

	chip->base = -1;

	chip->ngpio = WCD934X_NPINS;