Commit 67e40850 authored by Peter Griffin's avatar Peter Griffin Committed by Martin K. Petersen
Browse files

scsi: ufs: exynos: Move phy calls to .exit() callback 



ufshcd_pltfrm_remove() calls ufshcd_remove(hba) which in turn calls
ufshcd_hba_exit().

By moving the phy_power_off() and phy_exit() calls to the newly created
.exit callback they get called by ufshcd_variant_hba_exit() before
ufshcd_hba_exit() turns off the regulators. This is also similar flow to
the ufs-qcom driver.

Signed-off-by: default avatarPeter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20250319-exynos-ufs-stability-fixes-v2-6-96722cc2ba1b@linaro.org


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent deac9ad4

drivers/ufs/host/ufs-exynos.c

+9 −6
Original line number Diff line number Diff line
@@ -1522,6 +1522,14 @@ static int exynos_ufs_init(struct ufs_hba *hba) 
	return ret;

}



static void exynos_ufs_exit(struct ufs_hba *hba)

{

	struct exynos_ufs *ufs = ufshcd_get_variant(hba);



	phy_power_off(ufs->phy);

	phy_exit(ufs->phy);

}



static int exynos_ufs_host_reset(struct ufs_hba *hba)

{

	struct exynos_ufs *ufs = ufshcd_get_variant(hba);
@@ -1977,6 +1985,7 @@ static int gs101_ufs_pre_pwr_change(struct exynos_ufs *ufs, 
static const struct ufs_hba_variant_ops ufs_hba_exynos_ops = {

	.name				= "exynos_ufs",

	.init				= exynos_ufs_init,

	.exit				= exynos_ufs_exit,

	.hce_enable_notify		= exynos_ufs_hce_enable_notify,

	.link_startup_notify		= exynos_ufs_link_startup_notify,

	.pwr_change_notify		= exynos_ufs_pwr_change_notify,
@@ -2015,13 +2024,7 @@ static int exynos_ufs_probe(struct platform_device *pdev) 


static void exynos_ufs_remove(struct platform_device *pdev)

{

	struct ufs_hba *hba =  platform_get_drvdata(pdev);

	struct exynos_ufs *ufs = ufshcd_get_variant(hba);



	ufshcd_pltfrm_remove(pdev);



	phy_power_off(ufs->phy);

	phy_exit(ufs->phy);

}



static struct exynos_ufs_uic_attr exynos7_uic_attr = {