Commit 7f048b20 authored by Dan Carpenter's avatar Dan Carpenter Committed by Bjorn Andersson
Browse files

firmware: qcom: scm: Fix error code in probe() 



Set the error code if devm_qcom_tzmem_pool_new() fails.  Don't return
success.

Fixes: 1e76b546 ("firmware: qcom: scm: Cleanup global '__scm' on probe failures")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/a0845467-4f83-4070-ab1e-ff7e6764609f@stanley.mountain


Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
parent 1ac98d64

drivers/firmware/qcom/qcom_scm.c

+2 −2
Original line number Diff line number Diff line
@@ -2301,7 +2301,7 @@ static int qcom_scm_probe(struct platform_device *pdev) 


	__scm->mempool = devm_qcom_tzmem_pool_new(__scm->dev, &pool_config);

	if (IS_ERR(__scm->mempool)) {

		dev_err_probe(__scm->dev, PTR_ERR(__scm->mempool),

		ret = dev_err_probe(__scm->dev, PTR_ERR(__scm->mempool),

				    "Failed to create the SCM memory pool\n");

		goto err;

	}