Commit 7f05fd9a authored by Peter Griffin's avatar Peter Griffin Committed by Martin K. Petersen
Browse files

scsi: ufs: exynos: Ensure consistent phy reference counts 



ufshcd_link_startup() can call ufshcd_vops_link_startup_notify()
multiple times when retrying. This causes the phy reference count to
keep increasing and the phy to not properly re-initialize.

If the phy has already been previously powered on, first issue a
phy_power_off() and phy_exit(), before re-initializing and powering on
again.

Signed-off-by: default avatarPeter Griffin <peter.griffin@linaro.org>
Link: https://lore.kernel.org/r/20250319-exynos-ufs-stability-fixes-v2-4-96722cc2ba1b@linaro.org


Fixes: 3d73b200 ("scsi: ufs: ufs-exynos: Change ufs phy control sequence")
Cc: stable@vger.kernel.org
Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent f92bb743

drivers/ufs/host/ufs-exynos.c

+6 −0
Original line number Diff line number Diff line
@@ -962,6 +962,12 @@ static int exynos_ufs_phy_init(struct exynos_ufs *ufs) 
	}



	phy_set_bus_width(generic_phy, ufs->avail_ln_rx);



	if (generic_phy->power_count) {

		phy_power_off(generic_phy);

		phy_exit(generic_phy);

	}



	ret = phy_init(generic_phy);

	if (ret) {

		dev_err(hba->dev, "%s: phy init failed, ret = %d\n",