Commit 83646541 authored by Marco Crivellari's avatar Marco Crivellari Committed by Philipp Stanner
Browse files

drm/sched: Replace use of system_wq with system_percpu_wq 

In the general workqueue implementation, if a user enqueues a work item
using schedule_delayed_work() the used wq is "system_wq" (per-cpu wq)
while queue_delayed_work() use WORK_CPU_UNBOUND (used when a cpu is not
specified). The same applies to schedule_work() that is using system_wq
and queue_work(), that makes use again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.
For more details see the Link tag below.

This continues the effort to refactor worqueue APIs, which has begun
with the change introducing new workqueues and a new alloc_workqueue flag:

commit 128ea9f6 ("workqueue: Add system_percpu_wq and system_dfl_wq")
commit 930c2ea5 ("workqueue: Add new WQ_PERCPU flag")

Use the successor of system_wq, system_percpu_wq, for the scheduler's
default timeout_wq. system_wq will be removed in a few release cycles.

Link: https://lore.kernel.org/all/20250221112003.1dSuoGyc@linutronix.de/


Suggested-by: default avatarTejun Heo <tj@kernel.org>
Signed-off-by: default avatarMarco Crivellari <marco.crivellari@suse.com>
Signed-off-by: default avatarPhilipp Stanner <phasta@kernel.org>
Link: https://patch.msgid.link/20251106150121.256367-1-marco.crivellari@suse.com
parent dea9f847

drivers/gpu/drm/scheduler/sched_main.c

+1 −1
Original line number Diff line number Diff line
@@ -1320,7 +1320,7 @@ int drm_sched_init(struct drm_gpu_scheduler *sched, const struct drm_sched_init_ 
	sched->name = args->name;

	sched->timeout = args->timeout;

	sched->hang_limit = args->hang_limit;

	sched->timeout_wq = args->timeout_wq ? args->timeout_wq : system_wq;

	sched->timeout_wq = args->timeout_wq ? args->timeout_wq : system_percpu_wq;

	sched->score = args->score ? args->score : &sched->_score;

	sched->dev = args->dev;