Unverified Commit 90905f37 authored by Iker Pedrosa's avatar Iker Pedrosa Committed by Javier Martinez Canillas
Browse files

drm/solomon: Simplify get_modes() using DRM helper 



The ssd130x_connector_get_modes function contains a manual implementation
to manage modes.

This pattern is common for simple displays, and the DRM core already
provides the drm_connector_helper_get_modes_fixed() helper for this exact
use case.

Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: default avatarIker Pedrosa <ikerpedrosam@gmail.com>
Link: https://lore.kernel.org/r/20250920-improve-ssd130x-v2-4-77721e87ae08@gmail.com


Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
parent 7556fe21

drivers/gpu/drm/solomon/ssd130x.c

+1 −13
Original line number Diff line number Diff line
@@ -1732,20 +1732,8 @@ static const struct drm_encoder_funcs ssd130x_encoder_funcs = { 
static int ssd130x_connector_get_modes(struct drm_connector *connector)

{

	struct ssd130x_device *ssd130x = drm_to_ssd130x(connector->dev);

	struct drm_display_mode *mode;

	struct device *dev = ssd130x->dev;



	mode = drm_mode_duplicate(connector->dev, &ssd130x->mode);

	if (!mode) {

		dev_err(dev, "Failed to duplicated mode\n");

		return 0;

	}



	drm_mode_probed_add(connector, mode);

	drm_set_preferred_mode(connector, mode->hdisplay, mode->vdisplay);



	/* There is only a single mode */

	return 1;

	return drm_connector_helper_get_modes_fixed(connector, &ssd130x->mode);

}



static const struct drm_connector_helper_funcs ssd130x_connector_helper_funcs = {