Commit 913d28f8 authored by Cosmin Ratiu's avatar Cosmin Ratiu Committed by Jakub Kicinski
Browse files

net/mlx5e: Remove unused 'xsk' param of mlx5e_build_xdpsq_param 



This was added in commit [1], but its only use removed in commit [2].
The parameter is unused, so remove it from the function parameter list.

[1] commit 9ded70fa ("net/mlx5e: Don't prefill WQEs in XDP SQ in the
multi buffer mode")
[2] commit 1a930485 ("net/mlx5: XDP, Enable TX side XDP multi-buffer
support")
Signed-off-by: default avatarCosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: default avatarDragos Tatulea <dtatulea@nvidia.com>
Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 05dfe654

drivers/net/ethernet/mellanox/mlx5/core/en/params.c

+1 −2
Original line number Diff line number Diff line
@@ -1229,7 +1229,6 @@ static void mlx5e_build_async_icosq_param(struct mlx5_core_dev *mdev, 


void mlx5e_build_xdpsq_param(struct mlx5_core_dev *mdev,

			     struct mlx5e_params *params,

			     struct mlx5e_xsk_param *xsk,

			     struct mlx5e_sq_param *param)

{

	void *sqc = param->sqc;
@@ -1256,7 +1255,7 @@ int mlx5e_build_channel_param(struct mlx5_core_dev *mdev, 
	async_icosq_log_wq_sz = mlx5e_build_async_icosq_log_wq_sz(mdev);



	mlx5e_build_sq_param(mdev, params, &cparam->txq_sq);

	mlx5e_build_xdpsq_param(mdev, params, NULL, &cparam->xdp_sq);

	mlx5e_build_xdpsq_param(mdev, params, &cparam->xdp_sq);

	mlx5e_build_icosq_param(mdev, icosq_log_wq_sz, &cparam->icosq);

	mlx5e_build_async_icosq_param(mdev, async_icosq_log_wq_sz, &cparam->async_icosq);

drivers/net/ethernet/mellanox/mlx5/core/en/params.h

+0 −1
Original line number Diff line number Diff line
@@ -132,7 +132,6 @@ void mlx5e_build_tx_cq_param(struct mlx5_core_dev *mdev, 
			     struct mlx5e_cq_param *param);

void mlx5e_build_xdpsq_param(struct mlx5_core_dev *mdev,

			     struct mlx5e_params *params,

			     struct mlx5e_xsk_param *xsk,

			     struct mlx5e_sq_param *param);

int mlx5e_build_channel_param(struct mlx5_core_dev *mdev,

			      struct mlx5e_params *params,

drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c

+1 −1
Original line number Diff line number Diff line
@@ -54,7 +54,7 @@ static void mlx5e_build_xsk_cparam(struct mlx5_core_dev *mdev, 
				   struct mlx5e_channel_param *cparam)

{

	mlx5e_build_rq_param(mdev, params, xsk, &cparam->rq);

	mlx5e_build_xdpsq_param(mdev, params, xsk, &cparam->xdp_sq);

	mlx5e_build_xdpsq_param(mdev, params, &cparam->xdp_sq);

}



static int mlx5e_init_xsk_rq(struct mlx5e_channel *c,