Unverified Commit 9935af96 authored by Chun-Kuang Hu's avatar Chun-Kuang Hu Committed by AngeloGioacchino Del Regno
Browse files

soc: mediatek: cmdq: Remove cmdq_pkt_flush_async() helper function 



cmdq_pkt_flush_async() is not used by all client drivers (MediaTek
drm driver and MediaTek mdp3 driver), so remove it.

Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
Link: https://lore.kernel.org/r/20240222154120.16959-7-chunkuang.hu@kernel.org


Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
parent 3d86ced9

drivers/soc/mediatek/mtk-cmdq-helper.c

+0 −15
Original line number Diff line number Diff line
@@ -446,19 +446,4 @@ int cmdq_pkt_finalize(struct cmdq_pkt *pkt) 
}

EXPORT_SYMBOL(cmdq_pkt_finalize);



int cmdq_pkt_flush_async(struct cmdq_pkt *pkt)

{

	int err;

	struct cmdq_client *client = (struct cmdq_client *)pkt->cl;



	err = mbox_send_message(client->chan, pkt);

	if (err < 0)

		return err;

	/* We can send next packet immediately, so just call txdone. */

	mbox_client_txdone(client->chan, 0);



	return 0;

}

EXPORT_SYMBOL(cmdq_pkt_flush_async);



MODULE_LICENSE("GPL v2");

include/linux/soc/mediatek/mtk-cmdq.h

+0 −18
Original line number Diff line number Diff line
@@ -303,19 +303,6 @@ int cmdq_pkt_eoc(struct cmdq_pkt *pkt); 
 */

int cmdq_pkt_finalize(struct cmdq_pkt *pkt);



/**

 * cmdq_pkt_flush_async() - trigger CMDQ to asynchronously execute the CMDQ

 *                          packet and call back at the end of done packet

 * @pkt:	the CMDQ packet

 *

 * Return: 0 for success; else the error code is returned

 *

 * Trigger CMDQ to asynchronously execute the CMDQ packet and call back

 * at the end of done packet. Note that this is an ASYNC function. When the

 * function returned, it may or may not be finished.

 */

int cmdq_pkt_flush_async(struct cmdq_pkt *pkt);



#else /* IS_ENABLED(CONFIG_MTK_CMDQ) */



static inline int cmdq_dev_get_client_reg(struct device *dev,
@@ -436,11 +423,6 @@ static inline int cmdq_pkt_finalize(struct cmdq_pkt *pkt) 
	return -EINVAL;

}



static inline int cmdq_pkt_flush_async(struct cmdq_pkt *pkt)

{

	return -EINVAL;

}



#endif /* IS_ENABLED(CONFIG_MTK_CMDQ) */



#endif	/* __MTK_CMDQ_H__ */