Commit 9962ed64 authored by ZhangPeng's avatar ZhangPeng Committed by Andrew Morton
Browse files

mm/page_io: remove unneeded SetPageError() 

Nobody checks the PageError()/folio_test_error() for the page/folio in
__end_swap_bio_read/write() and sio_write_complete(). Therefore, we
don't need to set the error flag. Just drop it.

Link: https://lkml.kernel.org/r/20230721034451.16412-3-zhangpeng362@huawei.com


Signed-off-by: default avatarZhangPeng <zhangpeng362@huawei.com>
Suggested-by: default avatarMatthew Wilcox (Oracle) <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: Nanyong Sun <sunnanyong@huawei.com>
Cc: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 479c3304

mm/page_io.c

+0 −3
Original line number Diff line number Diff line
@@ -32,7 +32,6 @@ static void __end_swap_bio_write(struct bio *bio) 
	struct page *page = bio_first_page_all(bio);



	if (bio->bi_status) {

		SetPageError(page);

		/*

		 * We failed to write the page out to swap-space.

		 * Re-dirty the page in order to avoid it being reclaimed.
@@ -61,7 +60,6 @@ static void __end_swap_bio_read(struct bio *bio) 
	struct page *page = bio_first_page_all(bio);



	if (bio->bi_status) {

		SetPageError(page);

		pr_alert_ratelimited("Read-error on swap-device (%u:%u:%llu)\n",

				     MAJOR(bio_dev(bio)), MINOR(bio_dev(bio)),

				     (unsigned long long)bio->bi_iter.bi_sector);
@@ -415,7 +413,6 @@ static void sio_read_complete(struct kiocb *iocb, long ret) 
		for (p = 0; p < sio->pages; p++) {

			struct page *page = sio->bvec[p].bv_page;



			SetPageError(page);

			unlock_page(page);

		}

		pr_alert_ratelimited("Read-error on swap-device\n");