Commit 9f51ce0b authored by Yang Li's avatar Yang Li Committed by Bartosz Golaszewski
Browse files

gpio: mpc8xxx: Fix an ignored error return from platform_get_irq()



The return from the call to platform_get_irq() is int, it can be
a negative error code, however this is being assigned to an unsigned
int variable 'irqn', so making 'irqn' an int.

Eliminate the following coccicheck warning:
./drivers/gpio/gpio-mpc8xxx.c:391:5-21: WARNING: Unsigned expression
compared with zero: mpc8xxx_gc -> irqn < 0

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Fixes: 0b39536c ("gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe")
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 7c1cf555
Loading
Loading
Loading
Loading
+1 −1
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ struct mpc8xxx_gpio_chip {
				unsigned offset, int value);

	struct irq_domain *irq;
	unsigned int irqn;
	int irqn;
};

/*