Unverified Commit a5877e92 authored by Dmitry Torokhov's avatar Dmitry Torokhov Committed by Ilpo Järvinen
Browse files

platform/x86: barco-p50-gpio: convert to guard() notation 



Using guard notation simplifies control flow and makes the code clearer.

Suggested-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarDmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: default avatarBartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Link: https://patch.msgid.link/20260318-barco-p50-gpio-set-v2-2-c0a4a6416163@gmail.com


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
parent 1c9d30d3

drivers/platform/x86/barco-p50-gpio.c

+10 −16
Original line number Diff line number Diff line
@@ -272,33 +272,27 @@ static int p50_gpio_get(struct gpio_chip *gc, unsigned int offset) 
	struct p50_gpio *p50 = gpiochip_get_data(gc);

	int ret;



	mutex_lock(&p50->lock);

	guard(mutex)(&p50->lock);



	ret = p50_send_mbox_cmd(p50, P50_MBOX_CMD_READ_GPIO, gpio_params[offset], 0);

	if (ret == 0) {

		ret = p50_read_mbox_reg(p50, P50_MBOX_REG_DATA);

		if (ret >= 0)

			ret = !!ret;

	}



	mutex_unlock(&p50->lock);

	if (ret < 0)

		return ret;



	ret = p50_read_mbox_reg(p50, P50_MBOX_REG_DATA);

	if (ret < 0)

		return ret;



	return !!ret;

}



static int p50_gpio_set(struct gpio_chip *gc, unsigned int offset, int value)

{

	struct p50_gpio *p50 = gpiochip_get_data(gc);

	int ret;



	mutex_lock(&p50->lock);

	guard(mutex)(&p50->lock);



	ret = p50_send_mbox_cmd(p50, P50_MBOX_CMD_WRITE_GPIO,

	return p50_send_mbox_cmd(p50, P50_MBOX_CMD_WRITE_GPIO,

				 gpio_params[offset], value);



	mutex_unlock(&p50->lock);



	return ret;

}



static int p50_gpio_probe(struct platform_device *pdev)