Unverified Commit a5a8cad4 authored by Eugen Hristev's avatar Eugen Hristev Committed by AngeloGioacchino Del Regno
Browse files

dt-bindings: media: mtk-vcodec-encoder: fix non-vp8 clock name 



Looking at the binding it makes sense that the `-vp8` compatible has
the `venc_lt_sel` while the other bindings have the `venc_sel` as name for
the clock.
This was also mentioned in the txt version of the binding before the
conversion:
 `
 clock-names: avc encoder must contain "venc_sel", vp8 encoder must
 contain "venc_lt_sel", decoder must contain "vcodecpll", "univpll_d2",
 `

So it is easier to check for compatible that includes vp8, since that's
just one, to have the requirement for the clock name property as
`venc_lt_sel`, rather than for all the others, some of which are missing,
thus for them, the requirement is wrongly `venc_lt_sel`.

Reordered the if/then/else to match `-vp8` and have all the rest of
the compatibles using the other clock name (`venc_sel`).

Signed-off-by: default avatarEugen Hristev <eugen.hristev@collabora.com>
Reviewed-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20231228113245.174706-3-eugen.hristev@collabora.com


Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
parent 94e4dd09

Documentation/devicetree/bindings/media/mediatek,vcodec-encoder.yaml

+4 −7
Original line number Diff line number Diff line
@@ -109,10 +109,7 @@ allOf: 
      properties:

        compatible:

          enum:

            - mediatek,mt8173-vcodec-enc

            - mediatek,mt8188-vcodec-enc

            - mediatek,mt8192-vcodec-enc

            - mediatek,mt8195-vcodec-enc

            - mediatek,mt8173-vcodec-enc-vp8



    then:

      properties:
@@ -122,8 +119,8 @@ allOf: 
            maxItems: 1

        clock-names:

          items:

            - const: venc_sel

    else:  # for vp8 hw encoder

            - const: venc_lt_sel

    else:

      properties:

        clock:

          items:
@@ -131,7 +128,7 @@ allOf: 
            maxItems: 1

        clock-names:

          items:

            - const: venc_lt_sel

            - const: venc_sel



additionalProperties: false