Commit a8ebee57 authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Jakub Kicinski
Browse files

of: mdio: warn if deprecated fixed-link binding is used 



The array-style fixed-link binding has been marked deprecated for more
than 10 yrs, but still there's a number of users. Print a warning when
usage of the deprecated binding is detected.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/faf94844-96eb-400f-8a3a-b2a0e93b27d7@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 17a0374b

drivers/net/mdio/of_mdio.c

+2 −0
Original line number Diff line number Diff line
@@ -447,6 +447,8 @@ int of_phy_register_fixed_link(struct device_node *np) 
	/* Old binding */

	if (of_property_read_u32_array(np, "fixed-link", fixed_link_prop,

				       ARRAY_SIZE(fixed_link_prop)) == 0) {

		pr_warn_once("%pOF uses deprecated array-style fixed-link binding!\n",

			     np);

		status.link = 1;

		status.duplex = fixed_link_prop[1];

		status.speed  = fixed_link_prop[2];