Commit b3277087 authored by Zenghui Yu's avatar Zenghui Yu Committed by Thomas Gleixner
Browse files

irqchip/loongson-pch-msi: Fix off-by-one on allocation error path 



When pch_msi_parent_domain_alloc() returns an error, there is an off-by-one
in the number of interrupts to be freed.

Fix it by passing the number of successfully allocated interrupts, instead of the
relative index of the last allocated one.

Fixes: 632dcc2c ("irqchip: Add Loongson PCH MSI controller")
Signed-off-by: default avatarZenghui Yu <yuzenghui@huawei.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Reviewed-by: default avatarJiaxun Yang <jiaxun.yang@flygoat.com>
Link: https://lore.kernel.org/r/20240327142334.1098-1-yuzenghui@huawei.com
parent ff3669a7

drivers/irqchip/irq-loongson-pch-msi.c

+1 −1
Original line number Diff line number Diff line
@@ -136,7 +136,7 @@ static int pch_msi_middle_domain_alloc(struct irq_domain *domain, 


err_hwirq:

	pch_msi_free_hwirq(priv, hwirq, nr_irqs);

	irq_domain_free_irqs_parent(domain, virq, i - 1);

	irq_domain_free_irqs_parent(domain, virq, i);



	return err;

}