Commit b6c10a19 authored Dec 09, 2024 by Ping-Ke Shih

wifi: rtw89: 8852c: rfk: refine target channel calculation in _rx_dck_channel_calc()

The channel is not possibly 0, so original code is fine. Still want to
avoid Coverity warning, so ensure -32 offset for the channel number which
is larger than 125 only. Actually, don't change logic at all.

Addresses-Coverity-ID: 1628150 ("Overflowed constant")

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20241209042020.21290-1-pkshih@realtek.com

parent b59b86c5

drivers/net/wireless/realtek/rtw89/rtw8852c_rfk.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -1769,10 +1769,10 @@ u8 _rx_dck_channel_calc(struct rtw89_dev rtwdev, const struct rtw89_chan chan)
		target_ch = chan->channel - 33;
		}
		} else if (chan->band_type == RTW89_BAND_6G) {
		if (chan->channel >= 1 && chan->channel <= 125)
		target_ch = chan->channel + 32;
		else
		if (chan->channel > 125)
		target_ch = chan->channel - 32;
		else
		target_ch = chan->channel + 32;
		} else {
		target_ch = chan->channel;
		}