Commit bd268183 authored by furkanonder's avatar furkanonder Committed by Steven Rostedt (Google)
Browse files

tools/rtla: Enhance argument parsing in timerlat_load.py 

The enhancements made to timerlat_load.py are aimed at improving the clarity of argument parsing.

Summary of Changes:
- The cpu argument is now specified as an integer type in the argument
  parser to enforce input validation, and the construction of affinity_mask
  has been simplified to directly use the integer value of args.cpu.
- The prio argument is similarly updated to be of integer type for
  consistency and validation, eliminating the need for the conversion of
  args.prio to an integer, as this is now handled by the argument parser.

Cc: "jkacur@redhat.com" <jkacur@redhat.com>
Cc: "lgoncalv@redhat.com" <lgoncalv@redhat.com>
Link: https://lore.kernel.org/QfgO7ayKD9dsLk8_ZDebkAV0OF7wla7UmasbP9CBmui_sChOeizy512t3RqCHTjvQoUBUDP8dwEOVCdHQ5KvVNEiP69CynMY94SFDERWl94=@protonmail.com


Signed-off-by: default avatarFurkan Onder <furkanonder@protonmail.com>
Reviewed-by: default avatarTomas Glozar <tglozar@redhat.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent fc5f5aef

tools/tracing/rtla/sample/timerlat_load.py

+4 −5
Original line number Diff line number Diff line
@@ -25,13 +25,12 @@ import sys 
import os



parser = argparse.ArgumentParser(description='user-space timerlat thread in Python')

parser.add_argument("cpu", help='CPU to run timerlat thread')

parser.add_argument("-p", "--prio", help='FIFO priority')



parser.add_argument("cpu", type=int, help='CPU to run timerlat thread')

parser.add_argument("-p", "--prio", type=int, help='FIFO priority')

args = parser.parse_args()



try:

    affinity_mask = { int(args.cpu) }

    affinity_mask = {args.cpu}

except:

    print("Invalid cpu: " + args.cpu)

    exit(1)
@@ -44,7 +43,7 @@ except: 


if args.prio:

    try:

        param = os.sched_param(int(args.prio))

        param = os.sched_param(args.prio)

        os.sched_setscheduler(0, os.SCHED_FIFO, param)

    except:

        print("Error setting priority")