Commit bffa7218 authored by Yang Yingliang's avatar Yang Yingliang Committed by Vinod Koul
Browse files

dmaengine: fsl-edma: fix wrong pointer check in fsl_edma3_attach_pd() 



device_link_add() returns NULL pointer not PTR_ERR() when it fails,
so replace the IS_ERR() check with NULL pointer check.

Fixes: 72f5801a ("dmaengine: fsl-edma: integrate v3 support")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20231129090000.841440-1-yangyingliang@huaweicloud.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 0c154698

drivers/dma/fsl-edma-main.c

+2 −3
Original line number Diff line number Diff line
@@ -396,9 +396,8 @@ static int fsl_edma3_attach_pd(struct platform_device *pdev, struct fsl_edma_eng 
		link = device_link_add(dev, pd_chan, DL_FLAG_STATELESS |

					     DL_FLAG_PM_RUNTIME |

					     DL_FLAG_RPM_ACTIVE);

		if (IS_ERR(link)) {

			dev_err(dev, "Failed to add device_link to %d: %ld\n", i,

				PTR_ERR(link));

		if (!link) {

			dev_err(dev, "Failed to add device_link to %d\n", i);

			return -EINVAL;

		}