Commit c57ba40e authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones
Browse files

leds: bcm6358: Simplify with scoped for each OF child loop 



Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240816-cleanup-h-of-node-put-var-v1-8-1d0292802470@linaro.org


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 6a1d796e

drivers/leds/leds-bcm6358.c

+2 −5
Original line number Diff line number Diff line
@@ -147,7 +147,6 @@ static int bcm6358_leds_probe(struct platform_device *pdev) 
{

	struct device *dev = &pdev->dev;

	struct device_node *np = dev_of_node(&pdev->dev);

	struct device_node *child;

	void __iomem *mem;

	spinlock_t *lock; /* memory lock */

	unsigned long val;
@@ -184,7 +183,7 @@ static int bcm6358_leds_probe(struct platform_device *pdev) 
	}

	bcm6358_led_write(mem + BCM6358_REG_CTRL, val);



	for_each_available_child_of_node(np, child) {

	for_each_available_child_of_node_scoped(np, child) {

		int rc;

		u32 reg;
@@ -198,11 +197,9 @@ static int bcm6358_leds_probe(struct platform_device *pdev) 
		}



		rc = bcm6358_led(dev, child, reg, mem, lock);

		if (rc < 0) {

			of_node_put(child);

		if (rc < 0)

			return rc;

	}

	}



	return 0;

}