Commit c5e96e54 authored by Richard Fitzgerald's avatar Richard Fitzgerald Committed by Takashi Iwai
Browse files

ALSA: hda/cirrus_scodec_test: Fix incorrect setup of gpiochip 



Set gpiochip parent to the struct device of the dummy GPIO driver
so that the software node will be associated with the GPIO chip.

The recent commit e5d527be ("gpio: swnode: don't use the
swnode's name as the key for GPIO lookup") broke cirrus_scodec_test,
because the software node no longer gets associated with the GPIO
driver by name.

Instead, setting struct gpio_chip.parent to the owning struct device
will find the node using a normal fwnode lookup.

Signed-off-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Fixes: 2144833e ("ALSA: hda: cirrus_scodec: Add KUnit test")
Link: https://patch.msgid.link/20260113130954.574670-1-rf@opensource.cirrus.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent cbd46cbc

sound/hda/codecs/side-codecs/cirrus_scodec_test.c

+1 −0
Original line number Diff line number Diff line
@@ -103,6 +103,7 @@ static int cirrus_scodec_test_gpio_probe(struct platform_device *pdev) 


	/* GPIO core modifies our struct gpio_chip so use a copy */

	gpio_priv->chip = cirrus_scodec_test_gpio_chip;

	gpio_priv->chip.parent = &pdev->dev;

	ret = devm_gpiochip_add_data(&pdev->dev, &gpio_priv->chip, gpio_priv);

	if (ret)

		return dev_err_probe(&pdev->dev, ret, "Failed to add gpiochip\n");