Commit c8fb184f authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Madhavan Srinivasan
Browse files

powerpc: 52xx/gpio: use new line value setter callbacks 



struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Reviewed-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: default avatarMadhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20250502-gpiochip-set-rv-powerpc-v2-4-488e43e325bf@linaro.org
parent 5effda1c

arch/powerpc/platforms/52xx/mpc52xx_gpt.c

+4 −2
Original line number Diff line number Diff line
@@ -280,7 +280,7 @@ static int mpc52xx_gpt_gpio_get(struct gpio_chip *gc, unsigned int gpio) 
	return (in_be32(&gpt->regs->status) >> 8) & 1;

}



static void

static int

mpc52xx_gpt_gpio_set(struct gpio_chip *gc, unsigned int gpio, int v)

{

	struct mpc52xx_gpt_priv *gpt = gpiochip_get_data(gc);
@@ -293,6 +293,8 @@ mpc52xx_gpt_gpio_set(struct gpio_chip *gc, unsigned int gpio, int v) 
	raw_spin_lock_irqsave(&gpt->lock, flags);

	clrsetbits_be32(&gpt->regs->mode, MPC52xx_GPT_MODE_GPIO_MASK, r);

	raw_spin_unlock_irqrestore(&gpt->lock, flags);



	return 0;

}



static int mpc52xx_gpt_gpio_dir_in(struct gpio_chip *gc, unsigned int gpio)
@@ -334,7 +336,7 @@ static void mpc52xx_gpt_gpio_setup(struct mpc52xx_gpt_priv *gpt) 
	gpt->gc.direction_input  = mpc52xx_gpt_gpio_dir_in;

	gpt->gc.direction_output = mpc52xx_gpt_gpio_dir_out;

	gpt->gc.get = mpc52xx_gpt_gpio_get;

	gpt->gc.set = mpc52xx_gpt_gpio_set;

	gpt->gc.set_rv = mpc52xx_gpt_gpio_set;

	gpt->gc.base = -1;

	gpt->gc.parent = gpt->dev;