Commit d180c11a authored by Jian Shen's avatar Jian Shen Committed by Paolo Abeni
Browse files

net: hns3: using the num_tqps to check whether tqp_index is out of range when... 


net: hns3: using the num_tqps to check whether tqp_index is out of range when vf get ring info from mbx

Currently, rss_size = num_tqps / tc_num. If tc_num is 1, then num_tqps
equals rss_size. However, if the tc_num is greater than 1, then rss_size
will be less than num_tqps, causing the tqp_index check for subsequent TCs
using rss_size to always fail.

This patch uses the num_tqps to check whether tqp_index is out of range,
instead of rss_size.

Fixes: 326334aa ("net: hns3: add a check for tqp_index in hclge_get_ring_chain_from_mbx()")
Signed-off-by: default avatarJian Shen <shenjian15@huawei.com>
Signed-off-by: default avatarJijie Shao <shaojijie@huawei.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20251211023737.2327018-3-shaojijie@huawei.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent c2a16269

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c

+2 −2
Original line number Diff line number Diff line
@@ -193,10 +193,10 @@ static int hclge_get_ring_chain_from_mbx( 
		return -EINVAL;



	for (i = 0; i < ring_num; i++) {

		if (req->msg.param[i].tqp_index >= vport->nic.kinfo.rss_size) {

		if (req->msg.param[i].tqp_index >= vport->nic.kinfo.num_tqps) {

			dev_err(&hdev->pdev->dev, "tqp index(%u) is out of range(0-%u)\n",

				req->msg.param[i].tqp_index,

				vport->nic.kinfo.rss_size - 1U);

				vport->nic.kinfo.num_tqps - 1U);

			return -EINVAL;

		}

	}