Commit e32da5eb authored by Takashi Sakamoto's avatar Takashi Sakamoto Committed by Takashi Iwai
Browse files

ALSA: bebob: remove an unnecessary condition in hwdep_read() 



Drivers in ALSA firewire stack supports eventing to userspace
applications via ALSA hwdep interface. All of the drivers supports stream
lock events. Some of them supports their unique events according to
specification of target device.

ALSA bebob driver supports the stream lock event only. In the case, it's
enough to check condition only in loop with process blocking. However,
current implementation check it again after breaking the loop.

This commit removes the redundant check.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reported-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/20210125140208.26318-1-o-takashi@sakamocchi.jp


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent f4514249

sound/firewire/bebob/bebob_hwdep.c

+3 −5
Original line number Diff line number Diff line
@@ -37,11 +37,9 @@ hwdep_read(struct snd_hwdep *hwdep, char __user *buf, long count, 


	memset(&event, 0, sizeof(event));

	count = min_t(long, count, sizeof(event.lock_status));

	if (bebob->dev_lock_changed) {

	event.lock_status.type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS;

	event.lock_status.status = (bebob->dev_lock_count > 0);

	bebob->dev_lock_changed = false;

	}



	spin_unlock_irq(&bebob->lock);