Commit f4514249 authored by Dan Carpenter's avatar Dan Carpenter Committed by Takashi Iwai
Browse files

ALSA: fireface: remove unnecessary condition in hwdep_read() 



Smatch complains that "count" is not clamped when "ff->dev_lock_changed"
and it leads to an information leak.  Fortunately, that's not actually
possible and the condition can be deleted.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://lore.kernel.org/r/YA6n6I8EcNAO5ZFs@mwanda


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 00f3a411

sound/firewire/fireface/ff-hwdep.c

+4 −6
Original line number Diff line number Diff line
@@ -35,13 +35,11 @@ static long hwdep_read(struct snd_hwdep *hwdep, char __user *buf, long count, 
	}



	memset(&event, 0, sizeof(event));

	if (ff->dev_lock_changed) {

	event.lock_status.type = SNDRV_FIREWIRE_EVENT_LOCK_STATUS;

	event.lock_status.status = (ff->dev_lock_count > 0);

	ff->dev_lock_changed = false;



	count = min_t(long, count, sizeof(event.lock_status));

	}



	spin_unlock_irq(&ff->lock);