Commit eb51c5a1 authored by Harry Wentland's avatar Harry Wentland Committed by Alex Deucher
Browse files

drm/amd/display: Set chroma taps to 1 if luma taps are 1 



When luma is unscaled we also want chroma to be pixel-perfect.
When luma taps are > 1 the result will be a blurred luma plane,
even when the image isn't scaled.

This makes IGT tests for CSC colorop pass.

Assisted-by: Claude: claude-sonnet-4.5
Reviewed-by: default avatarAlex Hung <alex.hung@amd.com>
Signed-off-by: default avatarHarry Wentland <harry.wentland@amd.com>
Signed-off-by: default avatarAlex Hung <alex.hung@amd.com>
Tested-by: default avatarDan Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 23dee18f

drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp.c

+6 −2
Original line number Diff line number Diff line
@@ -172,10 +172,14 @@ bool dpp1_get_optimal_number_of_taps( 
		scl_data->taps.h_taps_c = in_taps->h_taps_c;



	if (!dpp->ctx->dc->debug.always_scale) {

		if (IDENTITY_RATIO(scl_data->ratios.horz))

		if (IDENTITY_RATIO(scl_data->ratios.horz)) {

			scl_data->taps.h_taps = 1;

		if (IDENTITY_RATIO(scl_data->ratios.vert))

			scl_data->taps.h_taps_c = 1;

		}

		if (IDENTITY_RATIO(scl_data->ratios.vert)) {

			scl_data->taps.v_taps = 1;

			scl_data->taps.v_taps_c = 1;

		}

		if (IDENTITY_RATIO(scl_data->ratios.horz_c))

			scl_data->taps.h_taps_c = 1;

		if (IDENTITY_RATIO(scl_data->ratios.vert_c))

drivers/gpu/drm/amd/display/dc/dpp/dcn30/dcn30_dpp.c

+6 −2
Original line number Diff line number Diff line
@@ -524,10 +524,14 @@ bool dpp3_get_optimal_number_of_taps( 
		scl_data->taps.v_taps_c = max_taps_c;



	if (!dpp->ctx->dc->debug.always_scale) {

		if (IDENTITY_RATIO(scl_data->ratios.horz))

		if (IDENTITY_RATIO(scl_data->ratios.horz)) {

			scl_data->taps.h_taps = 1;

		if (IDENTITY_RATIO(scl_data->ratios.vert))

			scl_data->taps.h_taps_c = 1;

		}

		if (IDENTITY_RATIO(scl_data->ratios.vert)) {

			scl_data->taps.v_taps = 1;

			scl_data->taps.v_taps_c = 1;

		}

		if (IDENTITY_RATIO(scl_data->ratios.horz_c))

			scl_data->taps.h_taps_c = 1;

		if (IDENTITY_RATIO(scl_data->ratios.vert_c))