Commit f5adb1fa authored by André Draszik's avatar André Draszik Committed by Alexandre Belloni
Browse files

rtc: s5m: replace regmap_update_bits with regmap_clear/set_bits 



The regmap_clear_bits() and regmap_set_bits() helper macros state the
intention a bit more obviously.

Use those.

Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: default avatarAndré Draszik <andre.draszik@linaro.org>
Link: https://lore.kernel.org/r/20250409-s2mpg10-v4-30-d66d5f39b6bf@linaro.org


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 1dd60958

drivers/rtc/rtc-s5m.c

+4 −6
Original line number Diff line number Diff line
@@ -338,8 +338,8 @@ static int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) 


	/* On S2MPS13 the AUDR is not auto-cleared */

	if (info->device_type == S2MPS13X)

		regmap_update_bits(info->regmap, info->regs->udr_update,

				   S2MPS13_RTC_AUDR_MASK, 0);

		regmap_clear_bits(info->regmap, info->regs->udr_update,

				  S2MPS13_RTC_AUDR_MASK);



	return ret;

}
@@ -351,9 +351,7 @@ static int s5m_rtc_read_time(struct device *dev, struct rtc_time *tm) 
	int ret;



	if (info->regs->read_time_udr_mask) {

		ret = regmap_update_bits(info->regmap,

				info->regs->udr_update,

				info->regs->read_time_udr_mask,

		ret = regmap_set_bits(info->regmap, info->regs->udr_update,

				      info->regs->read_time_udr_mask);

		if (ret) {

			dev_err(dev,