Unverified Commit 3762d6c3 authored by Shuicheng Lin's avatar Shuicheng Lin Committed by Rodrigo Vivi
Browse files

drm/xe/gsc: Fix BO leak on error in query_compatibility_version() 



When xe_gsc_read_out_header() fails, query_compatibility_version()
returns directly instead of jumping to the out_bo label. This skips
the xe_bo_unpin_map_no_vm() call, leaving the BO pinned and mapped
with no remaining reference to free it.

Fix by using goto out_bo so the error path properly cleans up the BO,
consistent with the other error handling in the same function.

Fixes: 0881cbe0 ("drm/xe/gsc: Query GSC compatibility version")
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Reviewed-by: default avatarDaniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patch.msgid.link/20260417163308.3416147-1-shuicheng.lin@intel.com


Signed-off-by: default avatarShuicheng Lin <shuicheng.lin@intel.com>
(cherry picked from commit 8de86d0a843c32ca9d36864bdb92f0376a830bce)
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent dc2d9842

drivers/gpu/drm/xe/xe_gsc.c

+1 −1
Original line number Diff line number Diff line
@@ -166,7 +166,7 @@ static int query_compatibility_version(struct xe_gsc *gsc) 
				     &rd_offset);

	if (err) {

		xe_gt_err(gt, "HuC: invalid GSC reply for version query (err=%d)\n", err);

		return err;

		goto out_bo;

	}



	compat->major = version_query_rd(xe, &bo->vmap, rd_offset, proj_major);