Commit 7403e87c authored by Abel Vesa's avatar Abel Vesa Committed by Dmitry Baryshkov
Browse files

dt-bindings: display: msm: Fix reg ranges and clocks on Glymur 



The Glymur platform has four DisplayPort controllers. The hardware
supports four streams (MST) per controller. However, on Glymur the first
three controllers only have two streams wired to the display subsystem,
while the fourth controller operates in single-stream mode.

Add a dedicated clause for the Glymur compatible to require the register
ranges for all four stream blocks, while allowing either one pixel clock
(for the single-stream controller) or two pixel clocks (for the remaining
controllers).

Update the Glymur MDSS schema example by adding the missing p2, p3,
mst2link and mst3link register blocks. Without these, the bindings
validation fails. Also replace the made-up register addresses with the
actual addresses from the first controller to match the SoC devicetree
description.

Cc: stable@vger.kernel.org # v6.19
Fixes: 8f63bf90 ("dt-bindings: display: msm: Document the Glymur DiplayPort controller")
Fixes: 1aee577b ("dt-bindings: display: msm: Document the Glymur Mobile Display SubSystem")
Signed-off-by: default avatarAbel Vesa <abel.vesa@oss.qualcomm.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/708518/
Link: https://lore.kernel.org/r/20260303-glymur-fix-dp-bindings-reg-clocks-v4-1-1ebd9c7c2cee@oss.qualcomm.com


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
parent 4ce71cea

Documentation/devicetree/bindings/display/msm/dp-controller.yaml

+20 −1
Original line number Diff line number Diff line
@@ -253,7 +253,6 @@ allOf: 
            enum:

              # these platforms support 2 streams MST on some interfaces,

              # others are SST only

              - qcom,glymur-dp

              - qcom,sc8280xp-dp

              - qcom,x1e80100-dp

    then:
@@ -310,6 +309,26 @@ allOf: 
          minItems: 6

          maxItems: 8



  - if:

      properties:

        compatible:

          contains:

            enum:

              # these platforms support 2 streams MST on some interfaces,

              # others are SST only, but all controllers have 4 ports

              - qcom,glymur-dp

    then:

      properties:

        reg:

          minItems: 9

          maxItems: 9

        clocks:

          minItems: 5

          maxItems: 6

        clocks-names:

          minItems: 5

          maxItems: 6



unevaluatedProperties: false



examples:

Documentation/devicetree/bindings/display/msm/qcom,glymur-mdss.yaml

+10 −6
Original line number Diff line number Diff line
@@ -176,13 +176,17 @@ examples: 
                };

            };



            displayport-controller@ae90000 {

            displayport-controller@af54000 {

                compatible = "qcom,glymur-dp";

                reg = <0xae90000 0x200>,

                      <0xae90200 0x200>,

                      <0xae90400 0x600>,

                      <0xae91000 0x400>,

                      <0xae91400 0x400>;

                reg = <0xaf54000 0x200>,

                      <0xaf54200 0x200>,

                      <0xaf55000 0xc00>,

                      <0xaf56000 0x400>,

                      <0xaf57000 0x400>,

                      <0xaf58000 0x400>,

                      <0xaf59000 0x400>,

                      <0xaf5a000 0x600>,

                      <0xaf5b000 0x600>;



                interrupt-parent = <&mdss>;

                interrupts = <12>;